我的do while循环是不是因为这个功能而不能工作？

Question

我做了一个程序，它要求用户猜一个计算机正在思考的1-100的数字，在程序结束时，当用户猜到正确的数字时，我试图让程序问用户是否想再玩一次（重新启动程序）。

在程序的最后，当用户猜对了数字，我试图让程序问用户是否想再玩一次（重新启动程序）。

为了解决这个问题，我试着用一个 do while 循环& char repeat;. 循环几乎从程序的开始一直延伸到结束，尽管没有成功。有人知道我做错了什么吗？是不是因为函数 talfunktion循环无法通过？

代码：我做了一个程序，要求用户猜测计算机正在思考的1-100的数字。

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

int talfunktion (int tal, int guess, int tries, char repeat);

int main () {

do {
    srand(time(NULL));
    int tal = rand() % 100 + 1; //tal is the correct value that the code is thinking of 
    int guess; //guess is the guessed value of the user
    int tries = 0; // amount of tries it took until getting correct
    char repeat;


    printf("Psst, the right number is: %d \n", tal); // remove later, not relevant to uppg.

    printf("Im thinking of a number between 1 and 100, guess which!");
    printf("\nEnter: ");
    scanf("%d", &guess);
    guess = talfunktion(tal, guess, tries, repeat);

    getchar();
    getchar();
    return 0;

    }

    int talfunktion(int tal, int guess, int tries, char repeat) {
        do {
            if (guess < tal) {
                tries++;
                printf("\nYour guess is too low, try again!");
                printf("\nEnter: ");
                scanf("%d", &guess);
            }
            else if (guess > tal) {
                tries++;
                printf("\nYour guess is too high, try again!");
                printf("\nEnter: ");
                scanf("%d", &guess);
            }
        } while (guess > tal || guess < tal);

        if (guess == tal) {
            printf("\nCongratulations, that is correct!");
            tries++;
            printf("\nYou made %d attempt(s)", tries);
            printf("\nPlay Again? (y/n)");
            scanf("%c", &repeat);
    }
} while (repeat == 'y' || repeat == 'Y');


}

Answer 1

这是一个可能的解决方案

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

void talfunktion(int tal, int guess, int* tries)
{
            if (guess < tal)
            {
                (*tries)++;
                printf("\nYour guess is too low, try again!");
            }
            else if (guess > tal)
            {
                (*tries)++;
                printf("\nYour guess is too high, try again!");
            }
            else if (guess == tal)
            {
                (*tries)++;
                printf("\nCongratulations, that is correct!");
                printf("\nYou made %d attempt(s)", *tries);
            }
}

int main (void)
{
    int tal; //tal is the correct value that the code is thinking of
    int guess; //guess is the guessed value of the user
    int tries = 0; // amount of tries it took until getting correct
    char playAgain;

    do {
            srand(time(NULL));
            tal = rand() % 100 + 1; //tal is the correct value that the code is thinking of
            printf("\nIm thinking of a number between 1 and 100, guess which!");
            printf("\nEnter: ");
            scanf("%d", &guess);
            talfunktion(tal, guess, &tries);

            printf("\nPsst, the right number is: %d", tal); // remove later, not relevant to uppg.
            getchar(); //to halt the code for taking the input

            if(guess == tal)
            {
                tries = 0;
                printf("\nPlay Again? (y/n)\n");
                scanf("%c", &playAgain);
            }

    } while (playAgain != 'n');

return 0;
}

Answer 2

评论中提到了一些描述问题的东西，你应该看看。

• 不要在另一个函数中定义一个函数
• 慎重放置回车语句
• 在使用字符测试时，使用 char 变种
• 考虑简化你的逻辑比较。(例如 guess > tal || guess < tal 同为 guess != tal )
• 确保自动变量被放置在使用的地方可见。
• 在格式指定器中放置空格。" %c" for scanf() 来消耗换行符。 (而不是过度使用 getchar())

这里是您的代码的简化版本，并修改了 main 和 talfunktion 职能...

char talfunktion(int tal);

int main (void) {
     int tal=0;//remove from inside {...} to make it visible to rest of function
     char repeat = 'n';

     srand(time(NULL));
     tal = rand() % 100 + 1; //tal is the correct value that the code is thinking of 

    do {

            repeat = talfunktion(tal);

        }while((tolower(repeat) == 'y'));

        return 0;
}

char talfunktion(int tal)//do all relevant work in function and return 
{                        //only what is necessary
     int guess = 0;
     char repeat = 'n';


    printf("Im thinking of a number between 1 and 100, guess which!");
    printf("\nEnter a number from 1 to 100: ");
    scanf("%d", &guess);
    if((guess < 1) || (guess > 100))
    {
        printf("Entered out of bounds guess...\n");
    }
    else if (guess != tal)
    {
        if(guess < tal) printf("guess too small\n");
        else printf("guess too large\n");
        printf("Try  again? <'n' or 'y'>\n");
        scanf(" %c", &repeat);//space in format specifier to consume newline character
        if(tolower(repeat) != 'y') return 'n';//tolower() allows both upper and lower case
    }
    else
    {
        printf("Congratulations: You guessed right.\n");
        printf("Play again? <'n' or 'y'>\n");
        scanf(" %c", &repeat);
    }
    return repeat;
}