[具有可变大小的2D数组作为参数C ++

Question

我打算创建一个函数Swap()，该函数交换矩阵A和矩阵B的n乘以n的两个最大元素。但是我有error: declaration of 'A' as multidimensional array must have bounds for all dimensions except the first

void Swap(int A[][], int B[][], int n, int m)
{
    int max_A = A[0][0];
    int max_B = B[0][0];
    int index_Ai, index_Aj, index_Bi, index_Bj;
    for(int i = 0; i < n; i++)
    {
        for(int j = 0; j < m; j++)
        {
            if(max_A < A[i][j])
            {
                max_A = A[i][j];
                index_Ai = i;
                index_Aj = j;
            }
        }
    }
    for(int i = 0; i < n; i++)
    {
        for(int j = 0; j < m; j++)
        {
            if(max_B < B[i][j])
            {
                max_B = B[i][j];
                index_Bi = i;
                index_Bj = j;
            }
        }
    }
    int temp;
     temp = A[index_Ai][index_Aj];
     A[index_Ai][index_Aj] = B[index_Bi][index_Bj];
     B[index_Bi][index_Bj] = temp;
}

我该如何处理这个问题？还是我应该只传递两个矩阵作为参数，然后在函数内找到它们的大小？任何帮助表示赞赏。

Answer 1

以下您的要求是使用向量的向量（又称2D向量，并带有注释：）来实现代码的可能性：

Live demo

#include <iostream>
#include <vector>
#include <exception>

//pass vectors by reference so the changes are reflected in the passed arguments
void Swap(std::vector<std::vector<int>> &A, std::vector<std::vector<int>> &B) {

    int max_A = A.at(0).at(0); //if indexing A[0][0], exception would not be thrown
    int max_B = B.at(0).at(0);
    int index_Ai, index_Aj, index_Bi, index_Bj;

    for (size_t i = 0; i < A.size(); i++) {
        for (size_t j = 0; j < A.at(0).size(); j++) {
            if (max_A < A[i][j]) { //indexing A[i][j] safe, cycle limited to vector size
                max_A = A[i][j];
                index_Ai = i;
                index_Aj = j;
            }
        }
    }
    for (size_t i = 0; i < B.size(); i++) {
        for (size_t j = 0; j < B.at(0).size(); j++) {
            if (max_B < B[i][j]) {
                max_B = B[i][j];
                index_Bi = i;
                index_Bj = j;
            }
        }
    }
    //standard library swap function
    std::swap(A.at(index_Ai).at(index_Aj), B.at(index_Bi).at(index_Bj));
}

int main() {

    std::vector<std::vector<int>> A = {{1, 2, 300}, {4, 9, 10, 56, 5, 6}};
    std::vector<std::vector<int>> B = {{10, 45, 2, 12, 20, 80}, {40, 45, 500, 60}};
    try{
        Swap(A, B);
    } catch(std::exception& e){ //if vectors accessed out of bounds throws exception
        std::cout << "ERROR: " << e.what() << std::endl; //we catch it here
        return EXIT_FAILURE;    
    }

    for (auto &v : A) { //test print A
        for (auto i : v) {
            std::cout << i << " ";
        }
        std::cout << std::endl;
    }
    std::cout << std::endl;
    for (auto &v : B) { //test print B
        for (auto i : v)
        {
            std::cout << i << " ";
        }
        std::cout << std::endl;
    }
    return EXIT_SUCCESS;
}

初始向量：

1 2 300
4 9 10 56 5 6

10 45 2 12 20 80
40 45 500 60

交换后：

1 2 500
4 9 10 56 5 6 

10 45 2 12 20 80
40 45 300 60

Answer 2

假设您的二维数组是“常规” C ++ 2D数组（不是矢量），请注意该数组将其数据存储在连续内存中。

鉴于这个事实，要在任何2D数组中找到最大元素，只需要知道尺寸，然后使用std::max_element获取指向每个数组的最大元素的指针，然后调用std::swap即可交换元素找到。

#include <algorithm>
#include <iostream>
//...
int main()
{
    const int m = 10;
    const int n = 20;

    int A[m][n] = {0};
    int B[m][n] = {0};

    // Test
    A[4][5] = 20;
    B[3][2] = 50;
    std::cout << "Before:\n" << A[4][5] << " " << B[3][2];                  

    // Swap the maximum elements  
    std::swap(*std::max_element(&A[0][0], &A[m-1][n]), 
              *std::max_element(&B[0][0], &B[m-1][n]));

    std::cout << "\n\nAfter:\n" << A[4][5] << " " << B[3][2];                  
}

输出：

Before:
20 50

After:
50 20

无需创建单独的功能。

---

如果必须创建一个函数，那么您可能正在寻找模板函数：

#include <algorithm>
#include <iostream>
//...

template <int M, int N>
void Swap(int A[M][N], int B[M][N])
{
    std::swap(*std::max_element(&A[0][0], &A[M-1][N]), 
              *std::max_element(&B[0][0], &B[M-1][N]));
}


int main()
{
    const int m = 10;
    const int n = 20;

    int A[m][n] = {0};
    int B[m][n] = {0};

    A[4][5] = 20;
    B[3][2] = 50;
    std::cout << "Before:\n" << A[4][5] << " " << B[3][2];                  

    Swap<10,20>(A, B);

    std::cout << "\n\nAfter:\n" << A[4][5] << " " << B[3][2];                  
}

输出：

Before:
20 50

After:
50 20