设计复杂的验证框架:从工厂找到正确的验证器

问题描述 投票:0回答:1

我正在设计一个验证框架,它将根据传递给 Validator 类的对象处理许多不同类型的验证。下面是基于工厂模式的实现。

验证器.java


/**
 * Validator interface
 *
 * @param <T> generic type
 * @param <M> generic type
 *
 */
@FunctionalInterface
public interface Validator<T, M extends Serializable> {
    /**
     * Validates target object
     *
     * @param object target object
     * @return map of errors (empty if valid)
     */
    Map<String, M> validate(T object);

    /**
     * Validates target object and throws exception in case
     * if list of errors is not empty
     *
     * @param object target object
     * @throws ValidationException if any validation errors exist
     */
    default void validateAndThrow(T object) throws ValidationException {
        Map<String, M> errors = validate(object);
        if (!errors.isEmpty()) {
            throw new ValidationException(errors);
        }
    }

    /**
     * Allows to configure validator if necessary
     *
     * @param visitor Validator visitor
     */
    default void configure(ValidatorVisitor visitor) {
        visitor.visit(this);
    }

    /**
     * Validator visitor functional interface
     */
    @FunctionalInterface
    interface ValidatorVisitor {

        /**
         * Action to be performed on a validator
         *
         * @param validator target validator
         */
        void visit(Validator validator);
    }
}

ValidatorFactory.java



/**
 * Implementation of validation factory
 *
 * Created by Saransh Bansal on 15/05/2020
 */
@Component
public class ValidatorFactory {

    @Autowired
    List<Validator> validators;

    /**
     * Returns specific validator based on object's class.
     *
     * @param object target object
     * @return instance of {@link Validator}
     */
    public Validator getValidatorForObject(Object object) {
        return validators.stream()
                .filter(v -> {
                    System.out.println("....." + v.getClass());
                    // return v.getClass().isAssignableFrom(object.getClass()); - ???
                })
                .findFirst()
                .orElseThrow(() -> new GenericRuntimeException(ERROR_TYPE_VALIDATOR_NOT_FOUND.getText(
                        object == null ? "null" : object.getClass())));
    }
}

自定义验证器 - DocumentValidator.java


/**
 * Document upload Request validator
 *
 */
@Component
public class DocumentValidator implements Validator<DocumentDto, Serializable> {
    private static final long DEFAULT_MAX_FILE_SIZE = 5 * 1024L * 1024;

    @Value("${aap.apricot.document.allowedContentTypes:}#{T(java.util.Collections).emptyList()}")
    private List<String> allowedContentTypes;

    @Value("${aap.apricot.document.allowedFileNames:}#{T(java.util.Collections).emptyList()}")
    private List<String> allowedFileNames;

    @Value("${aap.apricot.document.max.size:" + DEFAULT_MAX_FILE_SIZE + "}")
    private long maxFileSize;

    @Override
    public Map<String, Serializable> validate(DocumentDto documentData) {
        notNull(documentData, ERROR_MSG_DOCUMENT_MISSED.getText());

        Map<String, Serializable> errors = new HashMap<>();

        if (isNull(documentData.getFile())) {
            errors.put(FIELD_DOCUMENT_FILE.getText(), ERROR_MSG_DOCUMENT_FILE_MISSED.getText());
        } else {
            String contentType = documentData.getFile().getContentType();
            String fileName = documentData.getFile().getOriginalFilename();

            if (isNull(documentData.getBusinessDate())) {
                errors.put(FIELD_DOCUMENT_FILE.getText(), buildMessage(ERROR_MSG_DOCUMENT_BUSINESS_DATE_MISSED.getText()));
            }
            if (documentData.getFile().getSize() > maxFileSize) {
                errors.put(FIELD_DOCUMENT_FILE.getText(), buildMessage(ERROR_MSG_DOCUMENT_FILE_SIZE_EXCEEDED.getText(), maxFileSize));
            }
            if (!isEmpty(allowedContentTypes) && contentType != null &&
                    allowedContentTypes.stream().noneMatch(contentType::equalsIgnoreCase)) {
                errors.put(FIELD_DOCUMENT_FILE.getText(), buildMessage(ERROR_MSG_DOCUMENT_RESTRICTED_CONTENT_TYPE.getText(), contentType));
            }
            if (!isEmpty(allowedFileNames) && fileName != null &&
                        allowedFileNames.stream().noneMatch(fileName::startsWith)) {
                errors.put(FIELD_DOCUMENT_FILE.getText(), buildMessage(ERROR_MSG_DOCUMENT_RESTRICTED_FILE_NAME.getText(), fileName));
            }
        }
        return errors;
    }
}

我似乎无法弄清楚如何从我的工厂类中正确返回验证器。 (参见ValidatorFactory.java中用

???
注释的代码)

任何人都可以帮忙吗?

java spring-boot factory-pattern
1个回答
1
投票

根据我的理解,您的工厂需要根据特定类型返回。

给你一个想法的粗略代码:

ValidatorFactory 将根据验证器是否支持给定对象从其验证器列表中进行过滤。

请记住,如果 >1 个验证器支持给定类型,那么您的过滤器将返回 2 个或更多。您只会返回 findFirst()。

选项 1:

Public class ValidatorFactory {

    validators.stream().filter(v -> v.supports(object.getClass()).findFirst();


}

public class DocumentValidator{

  public boolean supports(Class clazz){

   return true;
   }
}

选项2:

public class ValidatorFactory{
  
   private Map<Class, Validator> validatorAssociations = new HashMap<>();


   public Validator getValidator(Object object){
 
      return validatorAssociations.get(object.class);
   }
  
}

您将需要某种映射,无论是 ValidatorFactory 的责任(FactoryPattern 通常都是这种情况),还是将责任推给验证器以了解其自身的功能。由你决定。

© www.soinside.com 2019 - 2024. All rights reserved.