sonarLint：仅有条件地调用方法

Question

我有这段代码：

logger.error("Unauthorized error: {} with request {} from {} ",
        authException.getMessage(),
        request.getServletPath(),
        getClientIp(request));

和：

  private static String getClientIp(HttpServletRequest request) {

        String remoteAddr = "";

        if (request != null) {
            remoteAddr = request.getHeader("X-FORWARDED-FOR");
            if (remoteAddr == null || "".equals(remoteAddr)) {
                remoteAddr = request.getRemoteAddr();
            }
        }

        return remoteAddr;
    }

但是我有这个警告：

 Invoke method(s) only conditionally

Answer 1

您可以在登录前检查

isErrorEnabled

。

if (logger.isErrorEnabled())
    logger.error("Unauthorized error: {} with request {} from {} ",
        authException.getMessage(),
        request.getServletPath(),
        getClientIp(request));