Rails RecordNotFound无法找到具有ID的相册

Question

我处于嵌套资源Rails应用程序的结尾，但是我似乎无法弄清楚如何删除评论。我可以删除专辑了。我的评论属于相册。用户同时拥有相册和评论。

我还希望确保用户无法删除他们未撰写的评论。我认为那是我的错误出处。

我一直收到此错误：

ActiveRecord::RecordNotFound in AlbumsController#destroy
Couldn't find Album with 'id'=17
Extracted source (around line #57):
55
56
57
58
59
60


    def set_album
        @album = Album.find(params[:id])
    end

    def album_params

这里是我的评论控制者：

class ReviewsController < ApplicationController
    before_action :set_review, only: [:show, :delete, :edit, :update]
    before_action :set_current_user, only: [:index, :new, :edit, :delete]
    before_action :find_album, only: [:create, :edit]
    before_action :must_login, only: [:index, :new, :create, :edit, :update, :delete]

    def index
        @albums = Album.with_recent_reviews
    end

    def show
        #@reviews = Review.where("album_id = ?", params[:album_id])
    end

    def new
        if params[:album_id] && @album = Album.find_by(id: params[:client_id])
            @review = @album.reviews.build
        else
            redirect_to albums_path
        end
    end

    def create
        @review = current_user.reviews.build(review_params)
        @review.album = @album
        if @review.save
            redirect_to album_path(@album)
        else
            @album = @review.album
            render :new
        end
    end

    def edit
    end

    def update
        if @review.update(review_params)
            redirect_to album_path(params[:album_id])
        else
            render 'edit'
        end
    end

    def destroy
        if current_user.id == @review.user_id
            @review.destroy
            redirect_to album_path(params[:album_id])
        else
            flash[:error] = "Unable to delete your review. Please try again."
            redirect_to album_reviews_path(@review)
        #@review.destroy
        end
    end

    private

    def set_review
        @review = Review.find(params[:id])
    end

    def set_current_user
        @user = current_user
    end

    def find_album
        @album = Album.find(params[:album_id])
    end

    def review_params
        params.require(:review).permit(:title, :date, :content, :user_id, :album_id, album_attributes:[:artist, :title, :user_id])
    end

end

这是删除链接所在的我的评论索引表：

<% @albums.each do |album| %>
  <br>
  <br>
  <% if album.avatar&.attached? %>
    <image src="<%=(url_for(album.avatar))%>%" style="width:350px;height:350px;">
  <% end %>
  <br>
  <%= album.artist %> - <%= album.title %>
  <br>
  <%= link_to "View Album", album_path(album) %>
  <%= link_to "Edit Album", edit_album_path(album) %>
  <br><br>
  <% album.reviews.each do |review| %>
    <% unless review.id.nil? %>
        <small>Date written: <%= review.date %></small><br>
        <small>Written by: <%= review.user.name %></small><br>
        <strong>Title: <%= review.title %></strong><br>
        Review: <%= review.content %><br>
        <%= link_to "Edit Review", edit_album_review_path(album_id: album.id, id: review.id) %>
        <%= link_to 'Delete', album_path(album_id: album.id, id: review.id), method: :delete, data: { confirm: 'Are you sure?' } %>
        <br><br>
    <% end %>
<% end %>
  <br>
<% end %>

相册控制器：

class AlbumsController < ApplicationController
    before_action :set_album, only: [:show, :edit, :update, :destroy]
    before_action :must_login, only: [:new, :show, :create, :edit, :update, :destroy]

    def index
        @albums = Album.all
        @user = current_user
    end

    def show
        @review = @album.reviews.build
        @review.user = current_user
        # If you want to have some flag to indicate its status
        #@review.draft = true
        @review.save
        @reviews = Review.recent #scope
    end

    def new
        @album = Album.new
        @user = current_user
    end

    def create
        @user = User.find(current_user.id)
        @album = current_user.albums.build(album_params)
        @album.user_id = current_user.id
        if @album.save
            redirect_to album_path(@album)
        else
            render :new
        end
    end

    def edit
        @user = current_user
    end

    def update
        #@album = current_user.albums.build(album_params)
        @album.user_id = current_user.id
        if @album.update(album_params)
            redirect_to album_path(@album), notice: "Your album has been updated."
        else
            render 'edit'
        end
    end

    def destroy
        @album.delete
        redirect_to albums_path
    end

    private

    def set_album
        @album = Album.find(params[:id])
    end

    def album_params
        params.require(:album).permit(:artist, :title, :avatar, :user_id, review_attributes:[:title, :date, :content, :user_id, :album_id])
    end
end

Answer 1

您遇到的这个问题是因为您没有将相册传递给审阅控制器的销毁操作。评论销毁操作不知道要销毁哪个评论，因为它还需要一个album_id。尝试将您的评论销毁操作更改为此：

def destroy
  if current_user.id == @review.user_id
    @album.reviews.find(params[:id]).destroy
    redirect_to album_path(params[:album_id])
  else
     flash[:error] = "Unable to delete your review. Please try again."
     redirect_to album_reviews_path(@review)
  end
end

您还必须将您在评论控制器中的before_action更改为此：

before_action :find_album, only: [:create, :update, :destroy]