[Python中使用纸牌的优惠券收集者的问题

Question

在编写一个程序时遇到问题，该程序可以在获得每套花色之一之前模拟所需的一副纸牌中的选秀次数。我遇到了一个无限循环，我不确定如何摆脱它并获取所需的输出。

import random
def coupon_collector():
  suits=['Hearts','Diamonds','Spades','Clubs']
  cards=['Ace','2','3','4','5','6','7','8','9','10','Jack','Queen','King']
  def has_suit(cards,suit):
    for s in cards:
      if suit == s:
        return True
    return False
  def has_all_suits(cards):
    for suit in suits:
      if not has_suit(cards,suit):
        return False
    return True
  def main():
    deck=[]
    my_cards=[]
    j=0
    for i in range(52):
      deck.append(suits[i%4]+cards[int(i/4)])
    while not has_all_suits(my_cards):
      ind=random.randint(0,51)
      card=deck[ind]
      if not has_suit(my_cards,card[0]):
        my_cards.append(card)
      j+=1
    for card in my_cards:
      print(card[1],'of',card[0])
    print('Number of picks:',j)
  main()


coupon_collector()

Answer 1

问题是has_suit从不返回True，因为suit == s从不为True。 mycards列表中的每个元素都是一串与西服（例如“ Diamonds3”）相连的卡值。这意味着您正在检查"Diamonds" == "Diamonds3"等。相反，您应该检查if suit in s以查看字符串“ Diamonds3”中是否包含字符串“ Diamonds”。

另外，另一个函数内部的函数定义也有些奇怪且不必要。我编辑了您的代码：

import random
suits = ['Hearts', 'Diamonds', 'Spades', 'Clubs']
cards = ['Ace', '2', '3', '4', '5', '6', '7', '8', '9', '10', 'Jack', 'Queen', 'King']

def has_suit(cards, suit):
    for s in cards:
        if suit in s:
            return True
    return False

def has_all_suits(cards):
    for suit in suits:
        if not has_suit(cards, suit):
            return False
    return True

def main():
    deck = []
    my_cards = []
    j = 0
    for i in range(52):
        deck.append(suits[i%4] + cards[int(i/4)])

    while not has_all_suits(my_cards):
        ind = random.randint(0, 51)
        card = deck[ind]
        if not has_suit(my_cards, card[0]):
            my_cards.append(card)
        j += 1
    for card in my_cards:
        print(card)
    print('Number of picks:', j)

main()