我写了一个方面,我正在尝试用 junit 进行测试。 该方面有一个关于称为
setQuery
的第三方方法的@Around 建议。
在编译时它抱怨:Can't find referenced pointcut setQuery
这是我的方面:
@Component
@Aspect
public class ElasticsearchQuerySecurityAspect {
@Around("org.elasticsearch.action.search.SearchRequestBuilder.setQuery() && args(queryBuilder)")
public void addFilter(final ProceedingJoinPoint pjp, QueryBuilder queryBuilder) throws Throwable {
Object[] args = pjp.getArgs();
// Set the filter to use our plugin
FilterBuilder securityFilter = FilterBuilders.scriptFilter("visibility-filter")
.lang("native")
.addParam("visibility-field", "visibility")
.addParam("parameter", "default");
// Re-create original query with the filter applied
QueryBuilder newQuery = QueryBuilders.filteredQuery(queryBuilder,securityFilter);
log.info("Adding filter to search request");
// Tell the method to run with the modified parameter
args[0] = newQuery;
pjp.proceed(args);
}
}
这是我的联合测试:
@RunWith(SpringJUnit4ClassRunner.class)// NOTE #1
@ContextConfiguration(loader = AnnotationConfigContextLoader.class)
@EnableLoadTimeWeaving
@ComponentScan
public class ElasticsearchQuerySecurityTest {
Client client = mock(Client.class);
@Before
public void setUp() throws Exception {
}
@Test
public void test() {
SearchRequestBuilder s = new SearchRequestBuilder(client);
QueryBuilder qb = QueryBuilders.queryString("name:foo");
XContentBuilder builder;
try {
builder = XContentFactory.jsonBuilder();
qb.toXContent(builder, null);
assertEquals("{\"query_string\":{\"query\":\"name:foo\"}}",builder.string());
// Call setQuery() which will invoke the security advice and add a filter to the query
s.setQuery(qb);
builder = XContentFactory.jsonBuilder().startObject();
qb.toXContent(builder, null);
builder.endObject();
assertEquals("{\"query\": "+
"{ \"filtered\": "+
"{ \"query\": "+
"{ \"query_string\": "+
"{ \"name:foo\", } }, "+
"\"filter\": "+
"{ \"script\": "+
"{ \"script\": \"visibility-filter\","+
"\"lang\":\"native\", "+
"\"params\": "+
"{ \"visibility-field\":\"visibility\", "+
"\"parameter\":\"default\" } } } } } }",
builder.string());
} catch (IOException e) {
fail("We threw an I/O exception!");
}
}
}
我在类路径上也有这个 aop.xml:
<!DOCTYPE aspectj PUBLIC "-//AspectJ//DTD//EN" "http://www.eclipse.org/aspectj/dtd/aspectj.dtd">
<aspectj>
<weaver>
<include within="org.elasticsearch.action.search.*"/>
</weaver>
<aspects>
<aspect name="org.omaas.security.ElasticsearchQuerySecurityAspect"/>
</aspects>
</aspectj>
我用
@Around("execution(public * set*())")
尝试了一个方面,发现它只建议当前包中的东西。我如何让它应用于第 3 方包中的东西?
Spring AOP只能织入Spring Beans。由于您的第 3 方目标类不是 Spring bean,因此无法对其应用方面。为此,您需要使用更强大的 AspectJ,并且不依赖于 Spring 基于动态代理的“AOP lite”实现。
使用 AspectJ,您有两个选择:
编辑: 哦,顺便说一句,你的切入点语法无效。你不能写
@Around("org.elasticsearch.action.search.SearchRequestBuilder.setQuery() && args(queryBuilder)")
相反,你更需要像这样的东西
@Around("execution(* org.elasticsearch.action.search.SearchRequestBuilder.setQuery(*)) && args(queryBuilder)")
一个方法名是不够的,你必须告诉AOP框架你想要捕获它的
execution()
(在AspectJ中你也可以通过call()
捕获它的所有调用者)。其次,您不会通过指定一个没有任何参数的方法签名QueryBuilder
来捕获具有一个setQuery()
参数的方法,因此我建议您使用setQuery(*)
或者,如果您想更精确,setQuery(org.elasticsearch.index.query.QueryBuilder)
。您还需要在方法名称前面使用返回类型和/或修饰符,例如public
,或者再次使用像*
.这样的小丑