如何为此链接列表正确分配内存

Question

我似乎无法找到内存分配出错的地方。所有功能都能正常工作，但程序在执行过程中会随机崩溃。我知道错误是我如何为链表分配内存，但我似乎无法弄清楚哪个部分是错误的。

#include <iostream>
#include <string.h>
#include <stdio.h>
#include <cstring>

using namespace std;
void menu_function(void);
void command_execute(string command, string name1, string name2);
int hash_function(string str);
void insert_into_hashtable(int ascii_total, string name);
void add_friendship(int ascii_key, string name);
void print_friendships(int aascii_key);
void check_friendship(int ascii_key, string name);
void remove_friendship(int ascii_key, string name);

#define SIZE 125

struct friend_list {
    string name = "";
    struct friend_list * next;
};

typedef struct friend_list list;

struct user {
    string name;
    int key;
    friend_list * FriendList;
};

struct user * hashArray[SIZE];

int main(int argc,
    const char * argv[]) {

    menu_function();
    return 0;
}

void menu_function() {
    char user_input[100]; //this could limit the size of input
    string command;
    string name1 = "\0";
    string name2 = "\0";;
    char * token; ** strong text **
        int inputsize = 100;
    int i = 0;
    char delimit[] = " \t\r\n\v\f";
    while (1) {
        printf("\nP <Name> to create a person\n");
        printf("F <Name> <Name> record friendship\n");
        printf("U <Name> <Name> terminate friendship\n");
        printf("L <Name> print out friends of a specified person\n");
        printf("Q <Name> <Name>  check friendship status of two people\n");
        printf("X - terminate the progarm\n");

        // Determine user input and
        fgets(user_input, inputsize, stdin);
        //getline(&input, &inputsize, stdin);//takes in user input;

        //printf("input: %s", user_input);

        //parsing the string for the data within
        token = strtok(user_input, delimit);
        i = 0;
        while (token != NULL) {
            if (i == 0) {
                command = token;
                //cout<< command<<endl;
            }
            if (i == 1) {
                name1 = token;
                // cout<< name1<<":"<<endl;
            }
            if (i == 2) {
                name2 = token;
                //  cout<< name2<<":"<<endl;
                name1 = name1 + "\n";
            }
            token = strtok(NULL, " ");
            i++;
        }
        command_execute(command, name1, name2);
        command = '\0';
        name1 = '\0';
        name2 = '\0';
    }
}

void command_execute(string command, string name1, string name2) {
    //cout<<"command is: "<<command<<endl;

    switch (command[0]) {

    case 'P': //Create record of the person
        insert_into_hashtable(hash_function(name1), name1);
        break;
    case 'F': //Record friendship
        add_friendship(hash_function(name1), name2);
        add_friendship(hash_function(name2), name1);
        break;
    case 'U': //Terminate Friendship
        remove_friendship(hash_function(name1), name2);
        remove_friendship(hash_function(name2), name1);
        break;
    case 'L': //Print out the persons Friends
        print_friendships(hash_function(name1));
        break;
    case 'Q': //Check on friendship
        check_friendship(hash_function(name1), name2);
        break;
    case 'X': //Exit the program **** COMPLETED
        exit(1);
        break;

    default:
        cout << "Error occured based on your command please try again" << endl;
        break;
    }
}

int hash_function(string string) {
    //going to use the ASCI value of the name with different weights per array position to hash the names
    int ascii_key = 0;
    int ascii_total = 0;
    // cout<< string.length()<< endl;
    //cout<< string<< endl;
    for (int i = 0; i < string.length() - 1; i++) {
        ascii_total = (int) string[i] * (i * 3 + 1);
        //   cout<< string[i]<< endl;
    }
    ascii_key = ascii_total % SIZE;
    //deals with colisions through open hashing
    while (hashArray[ascii_key] != NULL && strcmp(hashArray[ascii_key] - > name.c_str(), string.c_str())) { //strcmp(hashArray[ascii_key]->name.c_str(), string.c_str())
        //hashArray[ascii_key] != NULL ||
        ascii_key++;
    }

    // ****** decide size of the hash table and then finished hashing function. Usually hash time is gonna be half full
    cout << ascii_key << endl;

    return ascii_key;
}

void insert_into_hashtable(int ascii_key, string name) {
    int k = 0;
    //get the hash key
    user * item = (user * ) malloc(sizeof(struct user));
    item - > name = name;
    item - > key = ascii_key;
    item - > FriendList = NULL;
    cout << ascii_key << endl;
    //collisions resolved by linear probing
    //store the user in the table

    hashArray[ascii_key] = item;
    k++;
    //free(item);
}

void add_friendship(int ascii_key, string name) {
    //gonna have to check for valid input on users
    list * add = (list * ) malloc(sizeof(struct friend_list));
    add - > name = name;
    add - > next = NULL;
    if (ascii_key == 13) {
        ascii_key = ascii_key;
    }
    /* if( hashArray[ascii_key]->FriendList->next == NULL )
     {
     cout<<hashArray[ascii_key]->FriendList<<endl;
     hashArray[ascii_key]->FriendList = temp;
     }
     else*/
    {
        add - > next = hashArray[ascii_key] - > FriendList;
        hashArray[ascii_key] - > FriendList = add;

    }
    free(add);
}

void print_friendships(int ascii_key) {
    friend_list * temp = (friend_list * ) malloc(sizeof(friend_list));
    temp = hashArray[ascii_key] - > FriendList;
    while (temp != NULL) {

        cout << temp - > name << endl;
        if (temp - > next == NULL) {
            free(temp);
            return;
        }
        temp = temp - > next;

    }
    //free(temp);
}

void check_friendship(int ascii_key, string name) {
    list * temp = (list * ) malloc(sizeof(struct friend_list));
    temp = hashArray[ascii_key] - > FriendList;
    while (temp != NULL) {
        if (strcmp(temp - > name.c_str(), name.c_str()) == 0) {
            cout << "Friendship exist" << endl;
            return;
        }
        temp = temp - > next;
    }
    cout << "No Record of Friendship" << endl;
    free(temp);
}

//need to finish
void remove_friendship(int ascii_key, string name) {
    list * temp = (list * ) malloc(sizeof(struct friend_list));
    list * prev = (list * ) malloc(sizeof(struct friend_list));
    temp = hashArray[ascii_key] - > FriendList;

    if (temp != NULL && temp - > name == name) {
        hashArray[ascii_key] - > FriendList = temp - > next; // Changed head
        // free old head
        return;
    }

    //not the head
    while (temp != NULL && temp - > name != name) {
        prev = temp;
        temp = temp - > next;
    }
    if (temp == NULL) return;

    // Unlink the node from linked list
    prev - > next = temp - > next;
    free(temp);
    free(prev);
}

Answer 1

可能有很多错误，但这是一个很大的错误

    user *item = (user*) malloc(sizeof(struct user));

应该

    user *item = new user;

在C ++中，你应该总是使用new。 new和malloc之间的区别在于malloc不会称任何构造函数。所以在你的user对象中，string name的构造函数不会被调用。因此，每当您尝试使用name时，您都会有未定义的行为（即潜在的崩溃）。并且如评论中所述，你也应该使用delete而不是free基本上是相同的原因。

看了一下代码后面有很多很多指针相关的bug。比如这个怎么样

list* temp  = (list*)malloc(sizeof(struct friend_list));
temp = hashArray[ascii_key]->FriendList;

暂时忘掉malloc vs new，看看上面的代码吧。你有一个指针temp，你指向一些分配的内存。然后你扔掉那个记忆，让temp指向hashArray[ascii_key]->FriendList。如果不使用它，分配内存有什么意义？然后通过释放函数末尾的内存来复合错误。

free(temp);

但是temp不再指向分配的内存（因为你把它指向朋友列表）。很明显，你还没有理解指针和内存分配。

这是你应该如何写这个功能

void check_friendship( int ascii_key, string name)
{
    list* temp = hashArray[ascii_key]->FriendList;
    while( temp != NULL)
    {
        if(strcmp(temp->name.c_str(), name.c_str()) == 0)
        {
            cout<<"Friendship exist"<<endl;
            return;
        }
        temp = temp->next;
    }
    cout<<"No Record of Friendship"<<endl;
}

根本看不到任何分配。我猜你脑子里有某种规则，不管有指针我必须分配一些记忆。这不是真的，分配是关于创建新对象。 check_friendship不会创建任何新对象（它只检查现有对象），因此它不需要分配或释放任何东西。

remove_friendship有同样的问题，因为它正在消除友谊它应该delete一个对象，（友谊被删除）但没有理由它分配任何东西。

add_friendship有相同的错误，但相反。 add_friendship应该为添加的友谊分配一个新对象，你这样做，但是然后你尝试在函数结束时释放对象。你在某种一揽子规则下运行，必须分配每个指针变量，然后释放，而不是逻辑思考每个函数需要创建或销毁的对象。