WPF线程死锁[关闭]

问题描述 投票:0回答:1

我可以从您那里找到有用的答案。我有WPF应用程序从API提取数据,我在执行以下代码时遇到线程死锁

private List<Clinic> _clinics;
        public List<Clinic> Clinics {
            get { return _clinics; }
            set { _clinics = value; OnPropertyChanged(); }
        }

        private Clinic _selectedClinic;
        public Clinic SelectedClinic {
            get { return _selectedClinic; }
            set {
                _selectedClinic = value; OnPropertyChanged();
                if (value != null)
                    OnSelectClinic(value).Wait();
            }
        }
private async Task OnSelectClinic(Clinic clinic) {
            try {
using (var request = await Client.GetAsync("URL OF API")) {
                if (request.IsSuccessStatusCode){
StaffList = await request.Content.ReadAsAsync<Staff>();
}

                var error = await request.Content.ReadAsStringAsync();
                throw new Exception(error);
            }
            } catch (Exception e) {
                Debug.WriteLine(e);
            }
        }

这是视图模型,并且Clinics,selectedClinic和Staff都绑定到View.XAML

这里是API方法

[HttpGet("FindAllByClinic/{clinicId}")]
        public async Task<IActionResult> FindAllByClinic(int clinicId) {
            try {
                return Ok(_mapper.Map<List<Staff>>(await _staffRepository
                    .FindAllBy(clinicId)));
            } catch (Exception e) {
                return BadRequest(e.Message);
            }
        }

这里是StaffRepository方法:

public async Task<ICollection<Staff>> FindAllBy(int clinicId, int medicalPointId) {
            var persons = await Context.Persons.FromSql("EXEC HR.GetPersonsByClinicId @ClinicId = 0," +
                                                        $"@EncryptPassword = '{DecryptPassword}'").ToListAsync();

            var staffs = await Context.Staff
                .Include(e => e.StaffClinics)
                .ThenInclude(e => e.Clinic)
                .ThenInclude(e => e.ClinicMedicalPoints)
                .Where(e => e.StaffClinics.Any(c => c.ClinicId == clinicId
                                                    && c.Clinic.ClinicMedicalPoints.Any(m => m.MedicalPointId
                                                    == medicalPointId)))
                .ToListAsync();

            foreach (var staff in staffs) {
                staff.Person = persons.FirstOrDefault(e => e.Id == staff.PersonId);
            }

            return staffs;
        }

问题是,当我从组合框选择诊所时,整个应用程序冻结如果我有任何错误,谁能给我建议或更正我的代码]

c# wpf api xaml ef-core-2.0
1个回答
1
投票
public Clinic SelectedClinic {
            get { return _selectedClinic; }
            set {
                _selectedClinic = value; OnPropertyChanged();
                if (value != null)
                    OnSelectClinic(value).Wait();
            }
        }

此设置程序非常糟糕,因为:

  1. 它引发一个带有OnPropertyChanged的事件-没关系-但随后它将继续在二传手身上执行昂贵的操作。您已经在发起一个事件,也许有些人应该订阅该事件并执行OnSelectClinic

  2. You're blocking on async code, which is a sin that causes deadlocks。通常,解决方案是用async代替阻塞等待,但是在这种情况下,您需要重新设计,以使属性设置器不负责触发和等待此操作。

© www.soinside.com 2019 - 2024. All rights reserved.