所以我基本上要做的是将我的长代码重构为更简单的代码。我在这个website找到了这段代码,我真的不明白代码里面发生了什么。我不认为这段代码会起作用,因为我使用不同的策略和方法然后是标准的。
站点代码片段:
//PermissionsServiceProvider.php
public function boot()
{
Permission::get()->map(function($permission){
Gate::define($permission->slug, function($user) use ($permission){
return $user->hasPermissionTo($permission);
});
});
}
有人可以解释这段代码究竟发生了什么吗?
我的代码:
// Posts Policy
Gate::define('post.view', 'App\Policies\Blog\PostsPolicy@view');
Gate::define('post.create', 'App\Policies\Blog\PostsPolicy@create');
Gate::define('post.update', 'App\Policies\Blog\PostsPolicy@update');
Gate::define('post.delete', 'App\Policies\Blog\PostsPolicy@delete');
Gate::define('post.publish', 'App\Policies\Blog\PostsPolicy@publish');
Gate::define('post.edit', 'App\Policies\Blog\PostsPolicy@edit');
Gate::define('post.global', 'App\Policies\Blog\PostsPolicy@global');
// Categories Policy
Gate::define('category.view', 'App\Policies\Blog\CategoriesPolicy@view');
Gate::define('category.create', 'App\Policies\Blog\CategoriesPolicy@create');
Gate::define('category.update', 'App\Policies\Blog\CategoriesPolicy@update');
Gate::define('category.delete', 'App\Policies\Blog\CategoriesPolicy@delete');
Gate::define('category.edit', 'App\Policies\Blog\CategoriesPolicy@edit');
Gate::define('category.global', 'App\Policies\Blog\CategoriesPolicy@global');
// Tags Policy
Gate::define('tag.view', 'App\Policies\Blog\TagsPolicy@view');
Gate::define('tag.create', 'App\Policies\Blog\TagsPolicy@create');
Gate::define('tag.update', 'App\Policies\Blog\TagsPolicy@update');
Gate::define('tag.delete', 'App\Policies\Blog\TagsPolicy@delete');
Gate::define('tag.edit', 'App\Policies\Blog\TagsPolicy@edit');
Gate::define('tag.global', 'App\Policies\Blog\TagsPolicy@global');
// Parts Section Policy
Gate::define('part.section.view', 'App\Policies\Parts\PartSectionsPolicy@view');
Gate::define('part.section.create', 'App\Policies\Parts\PartSectionsPolicy@create');
Gate::define('part.section.update', 'App\Policies\Parts\PartSectionsPolicy@update');
Gate::define('part.section.delete', 'App\Policies\Parts\PartSectionsPolicy@delete');
Gate::define('part.section.edit', 'App\Policies\Parts\PartSectionsPolicy@edit');
Gate::define('part.section.global', 'App\Policies\Parts\PartSectionsPolicy@global');
// Parts Policy
Gate::define('part.view', 'App\Policies\Parts\PartsPolicy@view');
Gate::define('part.create', 'App\Policies\Parts\PartsPolicy@create');
Gate::define('part.update', 'App\Policies\Parts\PartsPolicy@update');
Gate::define('part.delete', 'App\Policies\Parts\PartsPolicy@delete');
Gate::define('part.edit', 'App\Policies\Parts\PartsPolicy@edit');
Gate::define('part.global', 'App\Policies\Parts\PartsPolicy@global');
// Admin Management Policy
Gate::define('admin.global', 'App\Policies\AdminManagementPolicy@global');
// User Management Policy
Gate::define('user.global', 'App\Policies\UserManagementPolicy@global');
有没有办法从我的权限表中作为foreach循环执行此操作?这是一些伪代码:
foreach($permissions as $permission) {
Gate::define($permission->slug, 'App\Policies\' . $permission->category . 'Policy@' . $permission->name);
}
问题:如何使我的代码更紧凑,更容易阅读,如网站上的代码片段?
首先,该文章的作者根本没有使用策略,他创建了一个权限表,然后通过代码片段将他创建的权限绑定到laravel gate
Permission::get()->map(function($permission){
Gate::define($permission->slug, function($user) use ($permission){
return $user->hasPermissionTo($permission);
});
});
让我们逐行打破它
Permission::get() // Query all permissions defined in permissions database table
->map(function($permission){ // Foreach permission do the following
Gate::define($permission->slug, // Create new gate with the permission slug
function($user) use ($permission){
return $user->hasPermissionTo($permission); // the user table has many to many relation with permissions table, here we only check if $user is associated with $permission
});
});
为了使您的代码更具动态性,我建议您执行以下操作:
permission
数据库表roles
数据库表permission_role
数据库表role_user
数据库表belongsToMany
定义)belongsToMany
定义)belongsToMany
定义)global
权限的数量通过使用Gate::before
,您可以允许具有global
或root
权限的特定用户授权所有已定义的能力:
Gate::before(function ($user, $ability) {
if ($user->hasPermission('root-access')) {
return true;
}
});
如果实现数据库权限,则不再需要为每个模型创建策略,并且将动态地使用上述代码定义门。
就个人而言,您现有的代码很好。有用。它是可读的。虽然随着应用程序的增长,它可能会变得更加冗长,但它也可能不会。为什么要改进呢?
也就是说,这里有一些想法。您的大部分代码都是权限和策略实现之间的映射。例如,'part.view'
映射到'App\Policies\Parts\PartsPolicy@view
。无法删除此映射的“权重”:它只能被移动。
您可以考虑将其移动到更简单的配置文件,如下所示:
// config/permission-map.php
<?php return [
'post.view' => 'App\Policies\Blog\PostsPolicy@view',
'post.create' => 'App\Policies\Blog\PostsPolicy@create',
'post.update' => 'App\Policies\Blog\PostsPolicy@update',
'post.delete' => 'App\Policies\Blog\PostsPolicy@delete',
// etc...
];
然后在你的启动中你读取该配置并迭代:
// boot permissions
$permission_map = require_once('config/permission_map.php');
foreach ($permission_map as $permission => $policy_implementation) {
Gate::define($permission, $policy_implementation);
}
优势:添加新的策略映射只会更改最显着的信息,您不必考虑如何进行映射 - 今天是Gate::define
但明天可能是Sentry::policy
。此外,通过从代码中分离数据,您可以更自由地测试代码。
另一种方法可能是注释:在策略实现的DocBlock中,您编写自己的注释语法,然后解析并编译到配置文件中。沿着这条路线
namespace App\Policies\Blog;
class PostsPolicy {
/**
* @permission post.view
*/
public function view() { /* ... */ }
}
我个人而言,我不喜欢这个:它增加了一层内部框架,其价值我发现很难衡量。