我有一个building_table和api :: building_table,我想将来自building_table的数据作为默认值,但如果building_table中不存在数据,我想在api :: building_table中获取它。问题是在building_table中可能不存在但在api building_table中存在的属性。每个表中还有不同名称的列。
这是我的示例代码
def get_building_info
building = Building.find_by(id: params[:id])
api_building = Api::Building.find_by(id: params[:id])
building_hash = {}
building_hash[:name] = building.name || api_building.name
building_hash[:room] = building.room || api_building.room
building_hash[:rent] = building.rent || api_building.monthly_fee
...
end
有更优雅的方式吗?顺便说一句,这是我的控制器。
通用方法,接受密钥列表作为参数:
def get_building_info(keys = %i[name room rent].zip(%i[name room fee]))
building = Building.find_by(id: params[:id])
api_building = Api::Building.find_by(id: params[:id])
keys.map do |key, api_key|
[
key,
building.attributes[key.to_s] || api_building.attributes[api_key.to_s]
]
end.to_h
end
有许多解决方案可以实现这一点,但是,这里有一个更简单的解决方案:
def get_building_info
building = Hash.new
building[:name], building[:room] = desired_building.name, desired_building.room
end
private
def desired_building
Building.find_by(id: params[:id]) ||
Api::Building.find_by(id: params[:id])
end
我认为你是以正确的方式做到的,但building
变量将被覆盖,你需要定义一个新的变量,如building2 = {}
before_action :find_records, only: :get_building_info
def get_building_info
building_hash = {}
building_hash[:name] = building_name
building_hash[:room] = building_room
# OR
building_hash[:name], building_hash[:room] = building_name, building_room
end
private
def find_records
@building = Building.find_by(id: params[:id])
@api_building = Api::Building.find_by(id: params[:id])
end
def building_name
@building.name || @api_building.name
end
def building_room
@building.room || @api_building.room
end
你可以使用Enumerable#each_with_object:
attrs = [ %i[name name], %i[room room], %i[rent monthly_fee] ]
attrs.each_with_object({}) do |(name, alias_name), h|
h[name] = building[name] || api_building[alias_name]
end