为什么函数返回零?

问题描述 投票:0回答:1

我有两个功能来读取CSV数据文件并导入到二维数组。用一个简单的宏来调用这些功能,我总是得到正确的数组大小为导入的文件,但ImportCSV2Array()函数的返回值是不一致的。我已经包括诊断语句,其表明,指定为返回vaule(即,阵列的维数)的函数的变量是正确无论是在主叫和被叫功能即时窗口。然而,当我输入了一些文件,我得到返回0,我不明白为什么?请任何人都建议我缺少的是什么?

这里是调用函​​数

Public Function ImportDataLog() As Boolean

Dim headerArr() As Variant
Dim filePath As String
Dim csvret As Long

On Error Resume Next
' Open file dialog to get a test file name, including path.
filePath = Application.GetOpenFilename( _
                "Test Data Files (*.csv), *.csv", 1, _
                "Select Pressure Test File")
'Debug.Print "Selected file " & filePath

' Allocate basic array before using.
ReDim headerArr(1, 1)
csvret = 0
' Read csv file and fill array with data
Application.StatusBar = "Importing . . ."
csvret = ImportCSV2Array(filePath, headerArr)

' Here csvret and UBound(headerArr, 1) should match.
Debug.Print "Return " & csvret; " (UB) " & UBound(headerArr, 1) '!!

If csvret = 0 Then
    Application.StatusBar = "Error Importing Test Data!"
    ImportDataLog = False
    'Exit Function
End If

Debug.Print "LastRecord "; headerArr(UBound(headerArr, 1), UBound(headerArr, 2))
ImportDataLog = True
Application.StatusBar = False

End Function

CSV文件时通常是一个2行“测试头文件或“测试结果”的数千条记录的表格形式的文件。当我输入一个“头”文件输出为: -

Allocated Array 1 Rows X 37 Columns
Return 1 (UB) 1
LastRecord 50.000
True

返回和(UB)值一致预期。但输出的“结果”的文件是: -

Allocated Array 8498 Rows X 9 Columns
Return 0 (UB) 8498
LastRecord 5
True

在这里,我不明白为什么我得到“返回0(UB)8498`?

我打电话导入功能是这样的: -

' Function for importing data from csv files to 2D array.
Public Function ImportCSV2Array(csvFileName As String, ByRef arr() As Variant) As Long

Dim row_number As Long
Dim col_Offset As Integer
Dim LineFromFile As String
Dim LineItems() As String
Dim LineNum As Long
Dim Field As Variant
Dim FileNumber As Integer

FileNumber = FreeFile
Close #FileNumber
row_number = 0
Application.Calculation = xlCalculationManual

' First pass to gauge the array dimensions required
Open csvFileName For Input As #FileNumber
Do Until EOF(FileNumber)
    Line Input #FileNumber, LineFromFile
    row_number = row_number + 1
Loop ' Until EOF(FileNumber)

If InStr(1, LineFromFile, "END") >= 1 Then
    row_number = row_number - 1
End If
LineItems = Split(LineFromFile, ",")
' ReDim tha array to fit the incoming data
ReDim arr(0 To row_number - 1, 0 To UBound(LineItems))
row_number = 0
' Diagnostic to check array sized OK
Debug.Print "Allocated Array " & UBound(arr, 1) & " Rows X " & UBound(arr, 2); " Columns"
Close #FileNumber

' Now import the data to the array line by line.
Open csvFileName For Input As #FileNumber
Do Until EOF(FileNumber)
    Line Input #FileNumber, LineFromFile
    LineItems = Split(LineFromFile, ",")

    For Each Field In LineItems
        If Field <> "" Then
            arr(row_number, col_Offset) = LineItems(col_Offset)
            col_Offset = col_Offset + 1
        End If
    Next Field
    row_number = row_number + 1
    col_Offset = 0
    LineNum = LineNum + 1
Loop ' Until EOF(FileNumber)
Close #FileNumber

' Set return value to show array's first dimension
ImportCSV2Array = UBound(arr, 1)

Application.Calculation = xlCalculationAutomatic

End Function

这两个函数看起来做工精细,即导入数据还算可以,但我觉得,如果返回值是并不如预期我失踪,可能是重要后来当我处理阵列错误。有什么建议吗?

解决方案通过捕捉关闭问题的错误是一些文件的row_number被递增超过UBound(arr, 1)。因此,与位错误检查该解决方案的工作原理: -

Do Until EOF(FileNumber)
    Line Input #FileNumber, LineFromFile
    LineItems = Split(LineFromFile, ",")
    If row_number > UBound(arr, 1) Or InStr(1, LineFromFile, "END") >= 1 Then
        Exit Do
    End If
    For Each Field In LineItems
        If Field <> "" Then
            arr(row_number, col_Offset) = LineItems(col_Offset)
            col_Offset = col_Offset + 1
        End If
    Next Field
    row_number = row_number + 1
    col_Offset = 0
Loop ' UnLineNumtil EOF(FileNumber)

给出预期的结果:

Return 8498 (UB) 8498
LastRecord 5
True
excel vba
1个回答
1
投票

该错误是在这里,因为2的:

Debug.Print "LastRecord "; headerArr(UBound(headerArr, 1), UBound(headerArr, 2))

因为这是唯一的地方阵列是REDIM-ED,并且它不具有2在其第二尺寸:

ReDim headerArr(1, 1)

VBA using ubound on a multidimensional array

© www.soinside.com 2019 - 2024. All rights reserved.